[FakeSlave] Extend slaves to provide period data for properly testing PDOs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read function take the latest value out of the queue and assign to the system interface. Need tests.
destogl
commented
Jul 21, 2023
| message_thread = std::thread(std::bind(&SimpleSlave::fake_periodic_messages, this)); | ||
| } | ||
|
|
||
| void fake_periodic_messages() |
There was a problem hiding this comment.
Please add a short docstring for this method.
canopen_fake_slaves/include/canopen_fake_slaves/basic_slave.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Dr. Denis <[email protected]>
destogl
commented
Aug 6, 2023
canopen_fake_slaves/include/canopen_fake_slaves/basic_slave.hpp
Outdated
Show resolved
Hide resolved
ipa-vsp
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have extended FakeSlave to publish one more PDO asynchronously from everything else to extend and test capability of ros2_control components.