provide Target instead of generic QObject

ros-industrial · Oct 28, 2023 · d670de2 · d670de2
1 parent 98def99
commit d670de2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/project_manager/ros_run_configuration.cpp b/src/project_manager/ros_run_configuration.cpp
@@ -60,9 +60,9 @@ namespace Internal {
 
 const char ROS_RC_ID[] = "ROSProjectManager.ROSRunConfiguration";
 
-ROSRunConfiguration::ROSRunConfiguration(Target *parent, Utils::Id id) :
-    RunConfiguration(parent, id),
-    m_stepList(new RunStepList(this, Constants::ROS_RUN_STEP_LIST_ID))
+ROSRunConfiguration::ROSRunConfiguration(Target *target, Utils::Id id) :
+    RunConfiguration(target, id),
+    m_stepList(new RunStepList(target, Constants::ROS_RUN_STEP_LIST_ID))
 {
 }
 

diff --git a/src/project_manager/ros_run_configuration.h b/src/project_manager/ros_run_configuration.h
@@ -50,7 +50,7 @@ class ROSRunConfiguration : public ProjectExplorer::RunConfiguration
     friend class ROSRunConfigurationFactory;
 
 public:
-    ROSRunConfiguration(ProjectExplorer::Target *parent, Utils::Id id);
+    ROSRunConfiguration(ProjectExplorer::Target *target, Utils::Id id);
 
     // RunConfiguration
     QString disabledReason() const override;

diff --git a/src/project_manager/ros_run_step.cpp b/src/project_manager/ros_run_step.cpp
@@ -167,7 +167,7 @@ const char STEPS_PREFIX[] = "ProjectExplorer.RunStepList.Step.";
 
 
 RunStep::RunStep(RunStepList *rsl, Utils::Id id) :
-    ProjectConfiguration(rsl, id)
+    ProjectConfiguration(rsl->target(), id)
 {
     //
 }
@@ -249,10 +249,10 @@ bool RunStep::enabled() const
     return m_enabled;
 }
 
-RunStepList::RunStepList(QObject *parent, Utils::Id id) :
-    ProjectConfiguration(parent, id)
+RunStepList::RunStepList(ProjectExplorer::Target *target, Utils::Id id) :
+    ProjectConfiguration(target, id)
 {
-    Q_ASSERT(parent);
+    Q_ASSERT(target);
     setDefaultDisplayName(tr("Run"));
 }
 

diff --git a/src/project_manager/ros_run_step.h b/src/project_manager/ros_run_step.h
@@ -143,7 +143,7 @@ class RunStepList : public ProjectExplorer::ProjectConfiguration
     Q_OBJECT
 
 public:
-    RunStepList(QObject *parent, Utils::Id id);
+    RunStepList(ProjectExplorer::Target *target, Utils::Id id);
     ~RunStepList() override;
 
     void clear();