Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to Qt Creator 4.11 #418

Merged
merged 16 commits into from
Jan 18, 2021
Merged

Conversation

christian-rauch
Copy link
Member

PR with the "4.11" commit subset of #417

@v4hn Can you rebase your PR christian-rauch#1 on this and report any regressions since 4.9.2?

@Levi-Armstrong
Copy link
Member

@christian-rauch Do you want to wait on @v4hn review before merging?

@christian-rauch
Copy link
Member Author

@christian-rauch Do you want to wait on @v4hn review before merging?

Yes. I gave it a quick shot and the usual set of features that I use work. But if there are more issues, it's better to solve them now with the smaller set of commits.

@Levi-Armstrong
Copy link
Member

Sounds good. Ping me when ready. @christian-rauch Would you be interested in being added as a maintainer?

@christian-rauch
Copy link
Member Author

Would you be interested in being added as a maintainer?

Would that mean I can accept PR and publish updated upstream? I will probably provide updated PRs for the plugin if I have time and want to use a newer Qt Creator version.

@Levi-Armstrong
Copy link
Member

Levi-Armstrong commented Jan 15, 2021

Would that mean I can accept PR and publish updated upstream? I will probably provide updated PRs for the plugin if I have time and want to use a newer Qt Creator version.

All of the above.

I plan on create a snapcraft release once 4.14 is merged which should not take to long to do.

qt-creator/qt-creator@1b4766e
disabled these classes upstream, so the plugin should not use them either.
@christian-rauch
Copy link
Member Author

@Levi-Armstrong This can be merged now and a new 4.12 branch based on this can be created.

I am happy to become one of the maintainers.

@Levi-Armstrong Levi-Armstrong merged commit 88892f3 into ros-industrial:4.11 Jan 18, 2021
@Levi-Armstrong
Copy link
Member

@christian-rauch The new branch is created and I have given you write access.

@christian-rauch christian-rauch deleted the 4.11 branch January 18, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants