Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild with Qt Creator 14.0.2 due to ABI breakage between patch version #519

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

christian-rauch
Copy link
Member

@christian-rauch christian-rauch commented Nov 8, 2024

The patch updates between Qt Creator 14.0.1 and 14.0.2 seem to make the plugin partially ABI incompatible.

With Qt Creator 14.0.2 and the plugin compiled for Qt Creator 14.0.0, clicking the Line: / Col: widget in the top right of an opened source document

grafik

crashed Qt Creator for me. The backtrace with the Qt Creator debug symbols showed something inside Qt Creator unrelated to the plugin itself but related to the project:

1  QArrayDataPointer<std::pair<Utils::Id, QString>>::needsDetach                                                                                                                                                            qarraydatapointer.h 443  0x7fffd0961225 
2  QList<std::pair<Utils::Id, QString>>::append                                                                                                                                                                             qlist.h             823  0x7fffd0961225 
3  QList<std::pair<Utils::Id, QString>>::operator+=                                                                                                                                                                         qlist.h             681  0x7fffd0961225 
4  ProjectExplorer::Project::allGenerators                                                                                                                                                                                  project.cpp         1208 0x7fffd0961225 
5  operator()                                                                                                                                                                                                               projectexplorer.cpp 1335 0x7fffd097d545 
6  QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, ProjectExplorer::ProjectExplorerPlugin::initialize(const QStringList&, QString *)::<lambda()>>::call                                           qobjectdefs_impl.h  137  0x7fffd097d545 
7  QtPrivate::FunctorCallable<ProjectExplorer::ProjectExplorerPlugin::initialize(const QStringList&, QString *)::<lambda()>>::call<QtPrivate::List<>, void>                                                                 qobjectdefs_impl.h  345  0x7fffd097d545 
8  QtPrivate::QCallableObject<ProjectExplorer::ProjectExplorerPlugin::initialize(const QStringList&, QString *)::<lambda()>, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h  555  0x7fffd097d545 
9  ??                                                                                                                                                                                                                                                0x7ffff5fc066a 
10 Core::Internal::requestMenuUpdate                                                                                                                                                                                        actionsfilter.cpp   315  0x7fffe8549eaf 
11 Core::Internal::requestMenuUpdate                                                                                                                                                                                        actionsfilter.cpp   318  0x7fffe8549ed5 
12 Core::Internal::ActionsFilter::updateEnabledActionCache                                                                                                                                                                  actionsfilter.cpp   327  0x7fffe854be91 
13 ??                                                                                                                                                                                                                                                0x7ffff5fc066a 
14 Core::ICore::contextAboutToChange                                                                                                                                                                                        moc_icore.cpp       297  0x7fffe85149d5 
15 Core::Internal::ICorePrivate::updateContextObject                                                                                                                                                                        icore.cpp           2370 0x7fffe8689768 
16 Core::Internal::ICorePrivate::updateFocusWidget                                                                                                                                                                          icore.cpp           2365 0x7fffe8689a1c 
17 ??                                                                                                                                                                                                                                                0x7ffff5fc066a 
18 QApplication::focusChanged(QWidget *, QWidget *)                                                                                                                                                                                                  0x7ffff738282b 
19 QWidget::setFocus(Qt::FocusReason)                                                                                                                                                                                                                0x7ffff73d5c98 
20 QWidget::setFocus                                                                                                                                                                                                        qwidget.h           423  0x7fffe86fb09e 
21 Core::Internal::LocatorWidget::showText                                                                                                                                                                                  locatorwidget.cpp   965  0x7fffe86fb09e 
22 Core::Internal::Locator::showFilter                                                                                                                                                                                      qarraydatapointer.h 439  0x7fffe86e0bd3 
23 ??                                                                                                                                                                                                                                                0x7ffff5fc066a 
24 QAction::triggered(bool)                                                                                                                                                                                                                          0x7ffff6dad472 
25 ??                                                                                                                                                                                                                                                0x7ffff5fc066a 
26 QAction::triggered(bool)                                                                                                                                                                                                                          0x7ffff6dad472 
27 QAction::activate(QAction::ActionEvent)                                                                                                                                                                                                           0x7ffff6db0129 
28 QObject::event(QEvent *)                                                                                                                                                                                                                          0x7ffff5fb3d53 
29 QApplicationPrivate::notify_helper(QObject *, QEvent *)                                                                                                                                                                                           0x7ffff7384632 
30 QCoreApplication::notifyInternal2(QObject *, QEvent *)                                                                                                                                                                                            0x7ffff5f61d3a 
31 QCoreApplicationPrivate::sendPostedEvents(QObject *, int, QThreadData *)                                                                                                                                                                          0x7ffff5f6524d 
32 ??                                                                                                                                                                                                                                                0x7ffff621b223 
33 ??                                                                                                                                                                                                                                                0x7ffff4b145b5 
34 ??                                                                                                                                                                                                                                                0x7ffff4b73717 
35 g_main_context_iteration                                                                                                                                                                                                                          0x7ffff4b13a53 
36 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)                                                                                                                                                                        0x7ffff621aafa 
37 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>)                                                                                                                                                                                           0x7ffff5f6d573 
38 QCoreApplication::exec()                                                                                                                                                                                                                          0x7ffff5f6a00e 
39 main                                                                                                                                                                                                                     main.cpp            894  0x40f3f8       

Recompiling with Qt Creator 14.0.2 fixes the issue for me.

@christian-rauch christian-rauch marked this pull request as ready for review November 8, 2024 21:59
@christian-rauch christian-rauch merged commit 3fab089 into ros-industrial:devel Nov 8, 2024
4 checks passed
@christian-rauch christian-rauch deleted the fix_14.0.2 branch November 8, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants