Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a PR to address #1014 and support empy v4.
I started by reviewing the changelog for differences in markup syntax and scanning our template corpus for affected usage and updating it.
Of the new constructs that are present in our code, these are the ones that I found doing basic token scanning:
The new extension markup syntax
@((...))
is present via a grouping/one-tuple literal:I'm honestly not sure whether this will be affected but it's one to watch.
Use of
:
for “else” was already deprecated and has been removed. Use!
instead as in@(...?...!...)
The
!
syntax is already usable in empy3 so it's been updated.I haven't expanded out these changes to include all files but am instead focusing on
generate_release_script.py
in order to smoke out issues and will then apply patches across all affected code before broader testing.This is still very much a work-in-progress.