Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyparsing as a dependency #496

Closed
wants to merge 1 commit into from
Closed

add pyparsing as a dependency #496

wants to merge 1 commit into from

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Jan 9, 2018

Adding it as pip since it's not a rosdep key yet ros/rosdistro#16549

Fixes #495

@tfoote
add pyparsing as a dependency
e91dad5 
Adding it as pip since it's not a rosdep key yet ros/rosdistro#16549
@dirk-thomas
Copy link
Member

The Debian package python-catkin-pkg-modules should already bring in this dependency. Therefore this shouldn't be needed. catkin_pkg might need fixing instead.

@dirk-thomas
Copy link
Member

catkin_pkg already declares this: ros-infrastructure/catkin_pkg@92ee7f2#diff-419aa3e2c65a318d41b25af356c30f36R13

Maybe this only needs a new release of catkin_pkg?

@dirk-thomas
Copy link
Member

I will close this for the mentioned reasons.

@dirk-thomas dirk-thomas deleted the tfoote-patch-1 branch January 19, 2018 19:01
@nuclearsandwich nuclearsandwich mentioned this pull request Jan 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfoote @dirk-thomas @nuclearsandwich