Implement test fixture for faking the rosdistro repo #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was previously silently skipped when there wasn't an initialized and updated rosdep database present on the host. This change creates a 'fake' rosdep database locally and uses that to run the test. This decoupling also means that the test can run offline.
cottsay
force-pushed
the
cottsay/fake-rosdep
branch
from
6d02a54 to
f49efb1
Compare
|
Alternatively, if we want to keep this test as a sort of "outer loop integration test", I can update these changes to use the live rosdep database but redirect only the sources list and cache to a temporary directory to isolate the test from the host. If we do that, we'll need to continue to ensure that the live rosdep data is compatible with the test. |
tfoote
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Testing based on the mocked data makes more sense and is much better to have to make it repeatable.
Maybe a method or comment how to update the content. Aka # This content is mocking https://github.com/ros/rosdistro/rosindex-v4.yaml periodically this should be updated to a more recent snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was previously silently skipped when there wasn't an initialized and updated rosdep database present on the host. This change creates a 'fake' rosdep database locally and uses that to run the test. This decoupling also means that the test can run offline.