Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect author names from apostrophes with triple quotes #108

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Protect author names from apostrophes with triple quotes #108

merged 1 commit into from
Apr 18, 2024

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Apr 17, 2024

Fixes #104

@rkent rkent requested review from audrow and tfoote as code owners April 17, 2024 22:45
tfoote
tfoote approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triple quotes seem fine. Alternatively there's likely an escaping method that could assist have worked. But this seems to take care of it.

@tfoote tfoote merged commit c20cc54 into ros-infrastructure:main Apr 18, 2024
4 checks passed
@rkent rkent deleted the protect-apostrophes branch April 18, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author names with apostrophe are crashing rosdoc2 (example in image_common)
2 participants
@rkent @tfoote