Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url links in home page #113

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Apr 18, 2024

This adds the urls from the package to the home page.

Note these are not included in the index in this version. I could do that, but I think I would need to first generate an rst page containing just these links.

In any case, the home page is getting cluttered now with lots of stuff that is also accessible from the index. I plan to do a revamp of that, hiding many of the items that are in the index from the home page, and simplifying the home page. In that case these URLs would only be on the home page, and not in the index. I think that is the right decision, but it is a matter of opinion.

@rkent rkent requested review from audrow and tfoote as code owners April 18, 2024 20:23
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding this in. We are getting a bunch of info. It might make sense to have a standard info box that collects things like package.xml content and renders them consistently.

@tfoote tfoote merged commit 864b07f into ros-infrastructure:main Apr 18, 2024
4 checks passed
@rkent rkent deleted the package-links branch April 21, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants