Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, very few package authors actually set the package repository url, which is an official link in package.xml But in navigating documentation, it is very important to be able to move as smoothly as possible between the rosindex package entry, rosdoc2 entry, and the repo. The repo url is readily available in rosdistro, so this PR looks it up if missing, and adds it.
Note this requires that we know the currently active rosdistro, which is not something that can be discerned directly from the package source. So the PR looks for ROS_DISTRO in the environment, and uses that if found. I'm not sure if the build farm sets that or not for doc jobs, if not that will need to be done to support this.
This also adds a new level of complexity to rosdoc2, that it is now using external information downloaded from the internet instead of just the local repo information for its build. I have a certain reluctance to add that additional complexity, but I believe the link to the repo URL is really important in documentation, so I think it is worth adding this.