Skip to content

Commit

Permalink
Remove map_topic parameter and add migration note
Browse files Browse the repository at this point in the history
Signed-off-by: Luca Della Vedova <[email protected]>
  • Loading branch information
luca-della-vedova committed Nov 26, 2024
1 parent d027562 commit 744160e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 11 deletions.
11 changes: 0 additions & 11 deletions configuration/packages/configuring-costmaps.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,6 @@ Costmap2D ROS Parameters
Description
Minimum cost of an occupancy grid map to be considered a lethal obstacle.

:map_topic:

============== =======
Type Default
-------------- -------
string "map"
============== =======

Description
Topic of map from map_server or SLAM.

:map_vis_z:

============== =======
Expand Down
20 changes: 20 additions & 0 deletions migration/Jazzy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,23 @@ For example, if you specify `topic: scan` in the `voxel_layer` of a `local_costm
* User chosen topic is `scan`.
* Topic will be remapped to `/tb4/scan` without `local_costmap`.
* Use global topic `/scan` if you do not wish the node namespace to apply

Removed global map_topic from Costmap node
******************************************

In `PR #4715 <https://github.com/ros-navigation/navigation2/pull/4715>`_ the global `map_topic` parameter has been removed from the `Costmap2DROS` node. This parameterwas only used in the `StaticLayer` and should be defined as a parameter local to the `StaticLayer` instead, for example:

```
global_costmap:
global_costmap:
ros__parameters:
[...]
# Not supported anymore
map_topic: my_map
static_layer:
plugin: "nav2_costmap_2d::StaticLayer"
map_subscribe_transient_local: True
# Do this instead
map_topic: my_map

```

0 comments on commit 744160e

Please sign in to comment.