Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding disengagement param to docs for rotation shim controller #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion configuration/packages/configuring-rotation-shim-controller.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,18 @@ Rotation Shim Controller Parameters
============== ===========================

Description
Maximum angular distance, in radians, away from the path heading to trigger rotation until within.
Maximum angular distance, in radians, away from the path heading to trigger rotation

:angular_disengage_threshold:

============== ===========================
Type Default
-------------- ---------------------------
double 0.3925
============== ===========================

Description
Angular distance, in radians, away from the path heading to rotation until within (new as of Oct 1, 2024 - previous behavior rotated until ``angular_dist_threshold``).

:forward_sampling_distance:

Expand Down
6 changes: 6 additions & 0 deletions migration/Jazzy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,9 @@ In `PR #4675 <https://github.com/ros-navigation/navigation2/pull/4675>`_ a ``pub
Default value:

- true

Rotation Shim Disengagement Threshold
*************************************

The parameter ``angular_disengage_threshold`` was introduced as a new threshold for disengagement of the rotation in the rotation shim controller.
Previous behavior rotated until the ``angular_dist_threshold``, now it can rotate until the ``angular_disengage_threshold``, which can be set closer to the path's orientation if desired.
Loading