Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPP] Make new deceleration on cancelation an option #4238

Closed
SteveMacenski opened this issue Apr 4, 2024 · 6 comments
Closed

[RPP] Make new deceleration on cancelation an option #4238

SteveMacenski opened this issue Apr 4, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@SteveMacenski
Copy link
Member

Create a parameter for if we should cancel using deceleration (default true), then use that in the logic introduced in #4136 to bypass if needed

Finally, add the new parameter to documentation & add the new param to the RPP deceleration migration guide entry

@SteveMacenski SteveMacenski added the good first issue Good for newcomers label Apr 4, 2024
@SteveMacenski SteveMacenski changed the title [RP[P] Make new deceleration on cancelation an option [RPP] Make new deceleration on cancelation an option Apr 4, 2024
@doisyg
Copy link
Contributor

doisyg commented Apr 4, 2024

Maybe we could just use cancel_deceleration < 0.0 for disabling the behavior

@tanmay-dhasade
Copy link

Hi @SteveMacenski, I am new to open source contributions and would like to work on this, wanted to check in if someone is already working on this? Thanks

@jwdinius
Copy link

Let's say that a developer sets the value of the proposed parameter, call it apply_cancel_deceleration, to false, what should linear_vel be set to when cancelling_ is true (see here)? 0?

@doisyg
Copy link
Contributor

doisyg commented May 12, 2024

Let's say that a developer sets the value of the proposed parameter, call it apply_cancel_deceleration, to false, what should linear_vel be set to when cancelling_ is true (see here)? 0?

I would say 0.0, as before the cancel_deceleration was introduced

(also consider not using a new parameter but just cancel_deceleration < 0.0)

@SteveMacenski
Copy link
Member Author

@tanmay-dhasade no one is working on it yet, this would be a great first contribution!

@SteveMacenski
Copy link
Member Author

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants