-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RPP use_cancel_deceleration parameter #4441
Added RPP use_cancel_deceleration parameter #4441
Conversation
Signed-off-by: Jatin Patil <[email protected]>
2c173be
to
6a4a4d5
Compare
Signed-off-by: Jatin Patil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested it as well!
Great job @JatinPatil2003 Thanks for the contribution
@JatinPatil2003 Could you please also give in a PR for the documentation? Then we can get this inn.. Thanks! |
I have opened a PR for documentation ros-navigation/docs.nav2.org/pull/567 |
Thanks @JatinPatil2003 and @padhupradheep - great contributions! |
was about to press merge @SteveMacenski :-D |
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <[email protected]> * Fixed Linting code style Signed-off-by: Jatin Patil <[email protected]> --------- Signed-off-by: Jatin Patil <[email protected]>
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <[email protected]> * Fixed Linting code style Signed-off-by: Jatin Patil <[email protected]> --------- Signed-off-by: Jatin Patil <[email protected]>
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <[email protected]> * Fixed Linting code style Signed-off-by: Jatin Patil <[email protected]> --------- Signed-off-by: Jatin Patil <[email protected]>
Basic Info
Description of contribution in a few bullet points
Future work that may be required in bullet points
For Maintainers: