Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pointer free order in amcl to avoid use-after-free bug mentioned in #4068 #4069

Closed
wants to merge 2 commits into from

Conversation

GoesM
Copy link
Contributor

@GoesM GoesM commented Jan 25, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4068
Primary OS tested on Ubuntu22.04
Robotic platform tested on gazebo simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

make tf_listener_.reset() before lase_scan_filter_.reset()


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

Also, you need to do the DCO signoff. Click on the failed DCO job for more information

@GoesM
Copy link
Contributor Author

GoesM commented Jan 25, 2024

opps, i did git rebase --signoff however still face to failed DCO. So sorry that , i'd check it again.

@SteveMacenski
Copy link
Member

Still both failing (now linter for another reason from change)

@GoesM
Copy link
Contributor Author

GoesM commented Jan 25, 2024

It seems that I failed because it need just the only author but regard my local commit as another one author.
Screenshot from 2024-01-26 03-45-35

I'd close this PR and push another again.

sorry again for my unfamiliarity about it.

@GoesM GoesM closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants