Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4136 to iron: Add API to gracefully cancel a controller #4254

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Apr 10, 2024

Backport of #4136 to iron.

Feel free to close if this is too much of an api/abi break.

Only the implementation is backported, not the pure pursuit modifications as they modify behavior.


For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Contributor

mergify bot commented Apr 10, 2024

@Timple, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @iron, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski
Copy link
Member

Unfortunately this breaks API stability :( But otherwise I would have loved to, this is a really useful feature. Thankfully, Jazzy's only a month away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants