Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalid accesses on paths in path_longer_on_approach #4375

Conversation

lss0815
Copy link
Contributor

@lss0815 lss0815 commented May 29, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on (Ubuntu)
Robotic platform tested on (Custom Robot)
Does this PR contain AI generated software? (No)

Description of contribution in a few bullet points

  • We encountered a segmentation fault in the behavior tree while operating our robot. Upon investigation, we discovered that the PathLongerOnApproach node was causing these segmentation faults.
  • When the ComputePathToPoseAction sets an empty path in the behavior tree port path due to failure or cancellation, the path from PathLongerOnApproach can be empty. Without checking its size, the node encounters segmentation faults at that time.
  • Co-author: @JinyongJeong

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit 1f26900 into ros-navigation:main May 29, 2024
8 of 10 checks passed
@SteveMacenski
Copy link
Member

SteveMacenski commented May 29, 2024

Thanks @lss0815!

@lss0815 lss0815 deleted the behavior_tree/path_longer_on_approach/prevent_empty_path_on_first_time_check branch May 29, 2024 16:56
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
…igation#4375)

* Prevent invalid accesses on paths in path_longer_on_approach

* Fix format of the change
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
…igation#4375)

* Prevent invalid accesses on paths in path_longer_on_approach

* Fix format of the change
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 22, 2024
…igation#4375)

* Prevent invalid accesses on paths in path_longer_on_approach

* Fix format of the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants