Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use topic_name for get_costmap service #4420

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

otamachan
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4419
Primary OS tested on Ubuntu
Robotic platform tested on Tested locally
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Advertise get_costmap service using topic name.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, yes I see that. Strange that no one remarked upon this until now. Thanks!

@SteveMacenski
Copy link
Member

FYI @jwallace42 #3320

If you're using this, you may not be aware of this.

@SteveMacenski SteveMacenski merged commit 98e89ad into ros-navigation:main Jun 11, 2024
9 of 10 checks passed
@otamachan otamachan deleted the change-service-name branch June 12, 2024 02:42
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants