Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic reconfigure and export controller in docking #4429

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

ajtudela
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu 22.04
Robotic platform tested on Clara and Morphia robots
Does this PR contain AI generated software? Nop

Description of contribution in a few bullet points

  1. I added the callback for dynamic reconfigure to tune the docking controller in runtime.
  2. The docking controller is a library so can be used for other packages.

Description of documentation updates required from your changes

I don't think so.


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@ajtudela
Copy link
Contributor Author

How are we going to manage this type of changes with respect to the repository in opennav, do I apply the same changes there or leave the other unchanged?

Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
@SteveMacenski SteveMacenski merged commit 29ba4b1 into ros-navigation:main Jun 14, 2024
9 of 10 checks passed
@ajtudela ajtudela deleted the dock branch June 14, 2024 17:51
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
…ation#4429)

* Added dynamic reconfigure and export controller in docking

Signed-off-by: Alberto Tudela <[email protected]>

* Fix vector

Signed-off-by: Alberto Tudela <[email protected]>

* Update controller.cpp

Signed-off-by: Alberto Tudela <[email protected]>

---------

Signed-off-by: Alberto Tudela <[email protected]>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
…ation#4429)

* Added dynamic reconfigure and export controller in docking

Signed-off-by: Alberto Tudela <[email protected]>

* Fix vector

Signed-off-by: Alberto Tudela <[email protected]>

* Update controller.cpp

Signed-off-by: Alberto Tudela <[email protected]>

---------

Signed-off-by: Alberto Tudela <[email protected]>
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 23, 2024
…ation#4429)

* Added dynamic reconfigure and export controller in docking

Signed-off-by: Alberto Tudela <[email protected]>

* Fix vector

Signed-off-by: Alberto Tudela <[email protected]>

* Update controller.cpp

Signed-off-by: Alberto Tudela <[email protected]>

---------

Signed-off-by: Alberto Tudela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants