-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/port upown tests to new gazebo #4454
Merged
SteveMacenski
merged 5 commits into
ros-navigation:main
from
stevedanomodolor:feat/port_upown_tests_to_new_gazebo
Jun 20, 2024
Merged
Feat/port upown tests to new gazebo #4454
SteveMacenski
merged 5 commits into
ros-navigation:main
from
stevedanomodolor:feat/port_upown_tests_to_new_gazebo
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Signed-off-by: stevedan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
The first PR with |
Fixed the merge conflict, just waiting on CI again to make sure it all looks good and check the code cov changes! |
SteveMacenski
approved these changes
Jun 20, 2024
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 21, 2024
* minor speeling check Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> --------- Signed-off-by: stevedan <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
* minor speeling check Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> --------- Signed-off-by: stevedan <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
* minor speeling check Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> * minor changes Signed-off-by: stevedan <[email protected]> --------- Signed-off-by: stevedan <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Related to #4455
Future work that may be required in bullet points
For Maintainers: