Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call gz sim directly without shell=True for a clean exit #4456

Closed
wants to merge 3 commits into from

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jun 20, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on System tests on Gazebo simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

TODO:

  • If we're okay with this chance, I can update the rest of the launch files.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

azeey added 3 commits June 20, 2024 15:53
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey marked this pull request as ready for review June 21, 2024 20:29
@SteveMacenski
Copy link
Member

SteveMacenski commented Jul 3, 2024

Testing this right now with the full suite of tests and working well. I think we'll keep the python3 util in place so that optionality exists (its still generally useful, even outside of GZ, to bring down zombies)

Closing, new PR with the full suite ready. Thanks for the help @azeey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants