Reintroduce multirobot launch files with updates to TB3 with Harmonic #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]>
|
This pull request is in conflict. Could you fix it @SteveMacenski? |
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
savalena
pushed a commit
to savalena/navigation2
that referenced
this pull request
Jul 5, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <[email protected]> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <[email protected]> * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ros-navigation/nav2_minimal_turtlebot_simulation#11
.xacro