Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior tree node for extracting pose from path (backport #4518) #4523

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 5, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses open-navigation/opennav_coverage#64 #4516
Does this PR contain AI generated software? (No)

Description of contribution in a few bullet points

  • Added behavior tree node that extracts a pose from a path at a specific index

Description of documentation updates required from your changes

  • Need to document this behavior tree node

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #4518 done by [Mergify](https://mergify.com).

* add get pose from path action

Signed-off-by: MarcM0 <[email protected]>

* cleanup from PR suggestions

Signed-off-by: MarcM0 <[email protected]>

* Updates for main compatibility

Signed-off-by: MarcM0 <[email protected]>

* Lint and build fix

Signed-off-by: MarcM0 <[email protected]>

* More Lint and warnings

Signed-off-by: MarcM0 <[email protected]>

* More Lint and build

Signed-off-by: MarcM0 <[email protected]>

* remove code left over from older file

Signed-off-by: MarcM0 <[email protected]>

* fix test blackboard var name

Signed-off-by: MarcM0 <[email protected]>

* only populate pose frame if empty

Signed-off-by: MarcM0 <[email protected]>

* lint

Signed-off-by: MarcM0 <[email protected]>

---------

Signed-off-by: MarcM0 <[email protected]>
(cherry picked from commit 12a9c1d)
Copy link
Contributor Author

mergify bot commented Jul 5, 2024

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
..._tree/plugins/action/get_pose_from_path_action.hpp 100.00% <100.00%> (ø)
..._tree/plugins/action/get_pose_from_path_action.cpp 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit fa26cb4 into jazzy Jul 6, 2024
10 of 11 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4518 branch July 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants