Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward motion for graceful controller (backport #4527) #4554

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 23, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu 22.04
Robotic platform tested on Gazebo classic
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Fix computation of linear and angular velocities to allow correct backward motion.
  • It can be backported to other branches.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #4527 done by [Mergify](https://mergify.com).

* Fix backward motion for graceful controller

Signed-off-by: Alberto Tudela <[email protected]>

* Update smooth_control_law.cpp

Signed-off-by: Alberto Tudela <[email protected]>

---------

Signed-off-by: Alberto Tudela <[email protected]>
(cherry picked from commit d1ad640)
Copy link
Contributor Author

mergify bot commented Jul 23, 2024

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 684352a into jazzy Jul 24, 2024
9 of 10 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4527 branch July 24, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants