Switch nav2_amcl to use modern CMake idioms. #4564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This PR updates nav2_amcl to use modern CMake idioms.
This change is a little unusual in that it rearranges the hierarchy of CMakeLists.txt files. This is because the individual libraries (like map_lib) are used in some of the other libraries, and CMake was complaining about that. So I flattened the whole thing out and now build all of the libraries at the top-level.
This PR also contains a couple of fixes to previous packages where I failed to properly export the include directory.
Finally, this PR goes ahead and removes quite a bit of dead code from this package. This has been dead for quite a while, so I think it makes sense to remove it at this point.
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
Changing the rest of the packages in Navigation2 to use modern CMake idioms (PRs will be upcoming).
For Maintainers: