Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav2_behaviors to use modern CMake idioms. #4579

Merged

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Jul 30, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses Followup to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

This PR changes nav2_behaviors to use modern CMake idioms. In particular:

  1. Get rid of ament_target_dependencies() in favor of target_link_libraries()
  2. Make sure to export the target so downstream consumers can use it.
  3. Relegate rclcpp_action to a test_dependency, since it is only needed for tests.
  4. Move the include directory down one level in include/${PROJECT_NAME}, which is the ROS 2 best practice since Humble.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

There will be additional PRs upcoming to switch more of the Navigation2 codebase over to these idioms.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit c5e53c0 into ros-navigation:main Jul 30, 2024
11 checks passed
@clalancette clalancette deleted the clalancette/main-nav2-behaviors branch July 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants