Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp nav2_constrained_smoother to use modern CMake idioms. #4583

Conversation

clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Revamp nav2_constrained smoother to use modern CMake idioms:

  1. Switch all uses of ament_target_dependencies to target_link_libraries.
  2. Move the include directories down one level, which is best practice since Humble.
  3. Make a few dependencies PRIVATE, so we don't need to export them to downstream consumers.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of the wider work of #4357. As such, there will be follow-up PRs to transition more of the packages to modern CMake.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...nav2_constrained_smoother/constrained_smoother.hpp 100.00% <ø> (ø)
..._constrained_smoother/src/constrained_smoother.cpp 92.85% <ø> (ø)

... and 2 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 7dcbf76 into ros-navigation:main Aug 1, 2024
11 checks passed
@clalancette clalancette deleted the clalancette/main-nav2-constrained-smoother branch August 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants