Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nav2_planner to modern CMake idioms. #4592

Merged

Conversation

clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Change nav2_planner to modern CMake idioms:

  1. Switch from ament_target_dependencies() to target_link_libraries()
  2. Move the header files down one directory level, which has been best practice since Humble.
  3. Make sure to export the target so downstream packages can use it.
  4. Cleanup the dependencies to reflect what the package actually needs.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger work to convert all of Navigation2 to modern CMake idioms. The full list of packages still to convert can be found in #4357 (comment)

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
nav2_planner/src/planner_server.cpp 92.01% <ø> (ø)

@SteveMacenski SteveMacenski merged commit 9e90417 into ros-navigation:main Aug 5, 2024
11 checks passed
@clalancette clalancette deleted the clalancette/main-nav2-planner branch August 6, 2024 10:50
josephduchesne pushed a commit to josephduchesne/navigation2 that referenced this pull request Dec 10, 2024
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Joseph Duchesne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants