Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nav2_rotation_shim_controller to modern CMake idioms. #4599

Conversation

clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Change nav2_rotation_shim_controller to use modern CMake idioms:

  1. Switch from target_link_libraries to ament_target_dependencies
  2. Add an export target so downstream users can use it.
  3. Push the include directory down one level, which is best practice since Humble.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is part of a larger series updating Navigation2 to modern CMake idioms. There will be follow-up PRs to switch more of the packages over.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit 4d5b902 into ros-navigation:main Aug 6, 2024
9 of 10 checks passed
@clalancette clalancette deleted the clalancette/main-nav2-rotation-shim-controller branch August 6, 2024 20:55
josephduchesne pushed a commit to josephduchesne/navigation2 that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants