Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 support for noetic #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

python3 support for noetic #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d78f9
Depend on python or python3 version of packages depending on ROS_PYTH…
lucasw Oct 26, 2021
ce21461
fix with : 2to3 -w -f except .
k-okada Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<package>
<package format="3">

<name>camera_info_manager_py</name>
<version>0.2.3</version>
Expand All @@ -22,10 +22,12 @@
<build_depend>rostest</build_depend>
<build_depend>sensor_msgs</build_depend>

<run_depend>python-rospkg</run_depend>
<run_depend>python-yaml</run_depend>
<run_depend>rospy</run_depend>
<run_depend>sensor_msgs</run_depend>
<exec_depend condition="$ROS_PYTHON_VERSION == 2">python-rospkg</exec_depend>
<exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-rospkg</exec_depend>
<exec_depend condition="$ROS_PYTHON_VERSION == 2">python-yaml</exec_depend>
<exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-yaml</exec_depend>
<exec_depend>rospy</exec_depend>
<exec_depend>sensor_msgs</exec_depend>

<test_depend>rosunit</test_depend>

Expand Down
2 changes: 1 addition & 1 deletion tests/test_camera_info_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def set_calibration(calib):
proxy = rospy.ServiceProxy('set_camera_info', SetCameraInfo)
rsp = proxy(calib)
return rsp
except rospy.ServiceException, e:
except rospy.ServiceException as e:
print("Service call failed: " + str(e))
return None

Expand Down