Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renamed rcpputils header #211

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix renamed rcpputils header #211

merged 1 commit into from
Nov 11, 2021

Conversation

aprotyas
Copy link
Contributor

@aprotyas aprotyas commented Nov 2, 2021

rcpputils/get_env.hpp is renamed to rcpputils/env.hpp as part of ros2/rcpputils#150, so the corresponding includes have been fixed in this PR.

Signed-off-by: Abrar Rahman Protyasha [email protected]

Signed-off-by: Abrar Rahman Protyasha <[email protected]>
@aprotyas
Copy link
Contributor Author

aprotyas commented Nov 2, 2021

The Rpr job fails as expected because the renamed header is not in a release yet.

CI from ros2/rcpputils#150:

Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25
Build/Test args: --packages-above-and-dependencies rcpputils
ROS distro: Rolling
Job: https://ci.ros2.org/job/ci_launcher/9287

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

CI (again) from ros2/rcpputils#150 following ros2/rcpputils@18b406b.

Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25
Build args: --packages-above-and-dependencies rcpputils
Test args: --packages-above rcpputils
ROS distro: Rolling
Job: https://ci.ros2.org/job/ci_launcher/9295

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@aprotyas
Copy link
Contributor Author

aprotyas commented Nov 4, 2021

@mjcarroll could I get a review on this please? Thanks!

@aprotyas
Copy link
Contributor Author

@mjcarroll thank you for the review! Now that ros2/rcpputils#150 has been merged, do you mind merging this PR please? Else we may see some yellow CI soon. 😆

@clalancette clalancette merged commit a90cedf into ros-perception:ros2 Nov 11, 2021
@aprotyas aprotyas deleted the aprotyas/rcpputils_fix_env_header branch November 11, 2021 16:33
@mhubii
Copy link

mhubii commented Mar 27, 2022

hey guys, isn't this still an issue? See

Ah okay, not in the foxy branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants