Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't raise unhandled exceptions in calibration #1054

Open
rursprung opened this issue Dec 4, 2024 · 0 comments
Open

don't raise unhandled exceptions in calibration #1054

rursprung opened this issue Dec 4, 2024 · 0 comments
Labels

Comments

@rursprung
Copy link
Contributor

various code in the calibration process throws exceptions which are then never handled. as a random example:

if self.pattern == Patterns.ChArUco:
if self.camera_model == CAMERA_MODEL.FISHEYE:
raise NotImplemented(
"Can't perform fisheye calibration with ChArUco board")

the big problem here is that this happens at the end, when you click "calibrate". in this specific case the exception is raised based on what the user has previously selected in the GUI with 0 indication beforehand for the user that this is not an acceptable option/combination. thus the whole calibration process (getting all the images) is completely lost and needs to be started again, creating a huge churn time for the user.

either the code never throws exceptions or the exceptions are handled by the GUI layer so that the message can be shown to the user without crashing the GUI. this then allows the user to select other options (or continue adding new data, etc.) without having to start over from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants