Update README.md #68
Merged
Update README.md #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ We provide a process to republish any topic speaking in a given transport to a d | |||
| e.g. have it subscribe to a topic you recorded encoded using draco and publish it as a raw, decoded message | |||
|
|
|||
| ```bash | |||
| ros2 run point_cloud_transport republish --in_transport draco --out_transport raw --ros-args --remap in:=input_topic_name --remap out:=ouput_topic_name | |||
| ros2 run point_cloud_transport republish --ros-args -p in_transport:=raw -p out_transport:=draco --remap in:=input_topic_name --remap out:=ouput_topic_name | |||
There was a problem hiding this comment.
i dont think this is working in humble atm
current command in README
ros2 run point_cloud_transport republish --in_transport draco --out_transport raw --ros-args --remap in:=input_topic_name --remap out:=ouput_topic_name
[INFO] [1711147262.122204435] [point_cloud_republisher]: The 'in_transport' parameter is set to: draco
[INFO] [1711147262.122278890] [point_cloud_republisher]: The 'out_transport' parameter is set to: raw
[INFO] [1711147262.127952488] [point_cloud_republisher]: Loading point_cloud_transport/raw_pub publisher
[INFO] [1711147262.129438348] [point_cloud_republisher]: out topic2: /ouput_topic_name
[INFO] [1711147262.129460088] [point_cloud_republisher]: Loading /in subscriber
[INFO] [1711147262.131488957] [point_cloud_republisher]: Subscribing to: /in/draco
[INFO] [1711147262.131516361] [point_cloud_republisher]: in topic: /in/draco
the proposed change
ros2 run point_cloud_transport republish --ros-args -p in_transport:=raw -p out_transport:=draco -p out.draco.force_quantization:=true --remap in:=input_topic_name --remap out:=ouput_topic_name
[INFO] [1711147186.463912785] [point_cloud_republisher]: The 'in_transport' parameter is set to: raw
[INFO] [1711147186.463985041] [point_cloud_republisher]: The 'out_transport' parameter is set to:
[INFO] [1711147186.476469800] [point_cloud_republisher]: out topic1: /out
[INFO] [1711147186.476848324] [point_cloud_republisher]: Subscribing to: /input_topic_name
[INFO] [1711147186.476872754] [point_cloud_republisher]: in topic: /input_topic_name
There was a problem hiding this comment.
ahh i see, its because humble still uses republish.cpp via republish_program.cpp (which overrides in_transport and out_transport) whereas rolling just launches republish.cpp as a component. i'll see about syncing those.
There was a problem hiding this comment.
resolving this comment. i can address this here: #70
and then backport your README change to humble and iron.
john-maidbot
approved these changes
Mar 22, 2024
|
also you could maybe replace "--remap " with "-r" as i think that is more concise |
ahcorde
added a commit
that referenced
this pull request
Mar 25, 2024
ahcorde
added a commit
that referenced
this pull request
Mar 25, 2024
ahcorde
added a commit
that referenced
this pull request
Mar 26, 2024
ahcorde
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rolling these parameters are fixed