Installed scripts, some minor fixes and warnings (#6)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ros-perception · Sep 11, 2023 · e88295b · e88295b
1 parent 85d28ba
commit e88295b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -52,6 +52,12 @@ install(
   DESTINATION share/${PROJECT_NAME}
 )
 
+install(PROGRAMS
+  scripts/publisher.py
+  scripts/subscriber_old_school.py
+  DESTINATION lib/${PROJECT_NAME}
+)
+
 # linting tests
 if(BUILD_TESTING)
   find_package(ament_cmake_copyright REQUIRED)

diff --git a/scripts/publisher.py b/scripts/publisher.py
@@ -52,7 +52,7 @@ def pointCloud2ToString(msg: PointCloud2):
 
     rclpy.init(args=sys.argv)
 
-    bag_path = argv[1]
+    bag_path = sys.argv[1]
     serialization_format='cdr'
 
     storage_options = rosbag2_py.StorageOptions(

diff --git a/scripts/subscriber_old_school.py b/scripts/subscriber_old_school.py
diff --git a/src/my_encoder.cpp b/src/my_encoder.cpp
@@ -16,7 +16,7 @@
 
 #include <point_cloud_transport/point_cloud_codec.hpp>
 
-int main(int argc, char ** argv)
+int main(int /*argc*/, char ** /*argv*/)
 {
   auto logger_ = rclcpp::get_logger("my_encoder");