Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CI #7

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Added CI #7

merged 4 commits into from
Oct 9, 2023

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented Oct 5, 2023 •
edited
Loading

Added CI, to check that everything will be fine when I release this package

@ahcorde
Added CI
29428ca 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Oct 5, 2023
ahcorde added 3 commits October 5, 2023 12:14
@ahcorde
fix build
a8602d5 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
fix build
141d300 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
make linters happy
cf8823f 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from john-maidbot October 5, 2023 11:02
john-maidbot
john-maidbot reviewed Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the ci build is failing because point_cloud_transport_plugins is not being found. Not sure why though 🤔 is it because we don't specify it as a build_depend in package.xml yet it's listed as a dep in the cmakelists.txt?

@ahcorde
Copy link
Author

ahcorde commented Oct 5, 2023

Package is in rosdistro https://github.com/ros/rosdistro/blob/master/rolling/distribution.yaml#L3760-L3781

@john-maidbot
Copy link
Collaborator

To clarify, I'm trying to understand why this test fails

Rpr__point_cloud_transport_tutorial__ubuntu_jammy_amd64

The logs say that point_cloud_transport_plugins was not found by cmake. Which suggests rosdep isn't installing it, right?

john-maidbot
john-maidbot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this PR is adding CI but is not the reason CI fails. I'll create an issue to address the failing CI.

@john-maidbot john-maidbot mentioned this pull request Oct 6, 2023
Closed
@ahcorde ahcorde merged commit 05e3de0 into rolling Oct 9, 2023
3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/ci branch October 9, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-maidbot john-maidbot john-maidbot approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @john-maidbot