Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point_cloud_transport_plugins does not need to be in CMakeLists.txt #9

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

john-maidbot
Copy link
Collaborator

@john-maidbot john-maidbot commented Oct 11, 2023

See here: ros-perception/point_cloud_transport#42

The package does not need point_cloud_transport_plugins to be in the cmake file as it is not a build dependency. This seemed to be causing the CI to fail since it was not finding the package at the build phase. (which is still odd though because the package should have been installed)

Before:
Rpr__point_cloud_transport_tutorial__ubuntu_jammy_amd64 Failed ❌

After:
Rpr__point_cloud_transport_tutorial__ubuntu_jammy_amd64 Passes ✅

@john-maidbot john-maidbot requested a review from ahcorde October 11, 2023 01:01
@ahcorde ahcorde merged commit 2337aa3 into rolling Oct 11, 2023
5 checks passed
@ahcorde ahcorde deleted the fix-ci branch October 11, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants