add opencv4 into the dependency list for ROS2 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lewis Liu <[email protected]>
ahcorde
reviewed
Apr 8, 2020
cv_bridge/CMakeLists.txt
Outdated
| @@ -37,7 +37,7 @@ else() | |||
| endif() | |||
|
|
|||
| find_package(sensor_msgs REQUIRED) | |||
| find_package(OpenCV 3 REQUIRED | |||
| find_package(OpenCV 4 REQUIRED | |||
There was a problem hiding this comment.
This line force to OpenCV4 , there is no option for version 3.
You should do something like:
find_package(OpenCV 4 QUIET opencv_core opencv_core)
if(NOT OpenCV_FOUND)
find_package(OpenCV 3 REQUIRED opencv_core opencv_core)
endif()
There was a problem hiding this comment.
It really works, I checked it and uploaded one new patch.
@ahcorde
ahcorde
requested changes
Apr 8, 2020
…ng from openCV installation situation.
chapulina
approved these changes
Apr 29, 2020
This was referenced Apr 29, 2020
|
@mjcarroll @ahcorde did you get a chance to look at this? |
ahcorde
approved these changes
Apr 30, 2020
mjcarroll
approved these changes
Apr 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gaoethan @ahcorde
I updated code to support OpenCV4 for branch ros2, please have a review.
Signed-off-by: Lewis Liu [email protected]