Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return statement in numpy import #346

Closed
wants to merge 1 commit into from

Conversation

jacobperron
Copy link
Contributor

Forward port of #292

This reflects a patch made in boostorg/python#218
I've also updated the return signature to match upstream.

Fixes #339


Note, to reproduce the reported error I first built vision_opencv with -DCMAKE_BUILD_TYPE=Release and then overlayed the camera_calibration package and ran it's tests.

This reflects a patch made in boostorg/python#218

I've also updated the return signature to match upstream.

Signed-off-by: Jacob Perron <[email protected]>
@mjcarroll
Copy link
Contributor

I also did this in #342 which is looking for a review 🤞

@jacobperron
Copy link
Contributor Author

I also did this in #342 which is looking for a review

Missed that one. Closing in favor of it.

@jacobperron jacobperron closed this Jul 9, 2020
@mjcarroll mjcarroll deleted the jacob/fwd_port_292 branch July 10, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants