Add rosaction CLI tool #115
Conversation
maximkulkin
force-pushed
the
rosaction-cli-tool
branch
from
393d5b5 to
2a2d9bc
Compare
maximkulkin
force-pushed
the
rosaction-cli-tool
branch
from
2a2d9bc to
f1f6f9b
Compare
maximkulkin
force-pushed
the
rosaction-cli-tool
branch
from
2a2d9bc to
279f435
Compare
maximkulkin
force-pushed
the
rosaction-cli-tool
branch
from
279f435 to
d50d1c4
Compare
|
Guys this PR is ready and passing. I'm a bit concerned on the whole "wait" thing in tests: you basically send something and wait for response and that waiting has a timeout but if system is under load, it might not be quick to respond and the test will fail. Although this approach seems to be ubiquitous. Otherwise please advise. |
|
This PR is ready to be merged. |
|
Ping! Can we get this PR merged? |
|
Just a +1 to say that if this works as expected it's a great addition that most users probably simply expect to be there (like I did, once). |
|
+1, i believe that conceptually action should have own interface to user. |
| catkin_install_python(PROGRAMS tools/axclient.py tools/axserver.py tools/dynamic_action.py tools/library.py | ||
| catkin_add_env_hooks(15.rosaction SHELLS bash DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/env-hooks) | ||
|
|
||
| catkin_install_python(PROGRAMS tools/rosaction tools/axclient.py tools/axserver.py tools/dynamic_action.py tools/library.py |
There was a problem hiding this comment.
You are installing some files that don't seem to be part of this PR. Were these intended to be here?
There was a problem hiding this comment.
I don't think he is, as hey only added the tools/rosaction and the env hooks for it.
| @@ -0,0 +1,140 @@ | |||
| import rosgraph | |||
There was a problem hiding this comment.
I believe that this is conceptually similar enough to the McGill code that it warrants including the full MIT license header as well as their copyright statement and a link to the original repository.
There was a problem hiding this comment.
I agree @maximkulkin could you dust off this PR and add the license of mcgill to the files?
Added rosaction CLI tool to list/get info/send actions, similar to rosservice tool.
Supported commands:
rosaction listrosaction info /actionrosaction type /actionrosaction type /action goalrosaction type /action feedbackrosaction type /action resultrosaction send /action "goal: 123"Closes #44