Fix sim time wait (#137) #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-rotter
suggested changes
May 20, 2019
| @@ -581,7 +581,8 @@ def wait_for_action_server_to_start(self, timeout=rospy.Duration(0.0)): | |||
| ## the user wait until the network connection to the server is negotiated | |||
There was a problem hiding this comment.
Would be great if we could use this diff to update also the documentation.
|
CI seems broken .. anyone around? |
|
anyone .. still alive here? |
fujitatomoya
approved these changes
Dec 16, 2019
|
LGTM |
|
the cpp SimpleActionClient has the same problem, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137.
To verify the bug, run the added test without the core changes, confirm that we run into the timeout.