Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosdep keys for pyparsing and pytest. #16549

Merged
merged 7 commits into from
Jan 10, 2018
Merged

Add rosdep keys for pyparsing and pytest. #16549

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08373ad
Add rosdep keys for pyparsing and pytest.
nuclearsandwich Dec 7, 2017
5725645
Drop gentoo key.
nuclearsandwich Dec 20, 2017
2bbd54c
Create a -pip key for python3-pytest on platforms where it is too old…
nuclearsandwich Dec 20, 2017
2c42770
Add python3-pytest key for Ubunbu Bionic.
nuclearsandwich Dec 21, 2017
c9ed02e
Remove python3-pytest-pip key.
nuclearsandwich Jan 2, 2018
2d4f78d
Don't bother scoping pytest to bionic.
nuclearsandwich Jan 3, 2018
7666915
Re-add python3-pytest keys for debian and gentoo.
nuclearsandwich Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rosdep/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4047,6 +4047,16 @@ python3-pep8:
python3-pkg-resources:
debian: [python3-pkg-resources]
ubuntu: [python3-pkg-resources]
python3-pyparsing:
arch: [python-pyparsing]
debian: [python3-pyparsing]
fedora: [python3-pyparsing]
gentoo: [dev-python/pyparsing]
ubuntu: [python3-pyparsing]
python3-pytest:
arch: [python-pytest]
ubuntu:
bionic: [python3-pytest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to just use ubuntu: [python3-pytest] in order to not need to maintain this in the future. The specific version requirement of ament_tools is just an arbitrary line in the sand. Any other package might have a different threshold.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is contrary to your first piece of feedback on this pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first comment was in the context of your proposal to add the rosdep keys in order to be used for the ROS 2 packages. In that context I mentioned that this will not work since we require a newer version.

During this discussion we have established that the ROS 2 packages can't use this new rosdep key since there is no Debian package available which is new enough. And in the context of just adding these rosdep keys for other packages I think it should not be limited to bionic.

python3-ruamel.yaml:
debian:
buster: [python3-ruamel.yaml]
Expand Down