Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_robots: 0.8.3-0 in 'melodic/distribution.yaml' [bloom] #20328

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

moriarty
Copy link
Contributor

Sorry for yet another PR.

I've ran the prerelease jobs, and the pass. When trying to run the binary release job locally with 0.8.3, it still seemed to build version 0.8.2, so I think I wasn't setting up rosdistro correctly.
If this doesn't work, I'll ask @jacobperron to give me a tutorial in running the binary release jobs locally when he's home next week.

The source of all these 0.8.0, 0.8.1, 0.8.3 releases is trying to release a pre-combiled binary version of our drivers on the public build farm. ZebraDevs/fetch_robots#27... we knew we were going to get into a bit of a mess at the beginning, hopefully it stabilizes.

Our pre-compiled binary is generated inside of docker and only targets intel / amd64.

So there is another open PR to blacklist the arm versions of our packages. ros-infrastructure/ros_buildfarm_config#125

@moriarty
Copy link
Contributor Author

@dirk-thomas the doughnuts in the kitchen now have no strings attached... Just a two merge requests (this and ros-infrastructure/ros_buildfarm_config#125).
Sorry @clalancette doughnuts are in MV.

I wasn't able to pre-test the binary build job this morning, but reviewed it with @jacobperron and it should pass this time, otherwise I'll setup a mock build farm tonight.

As recommended this morning, I'll put it on our to-do list to move the tarball from http://packages.fetchrobotics.com/binaries/ to inside the git package for future releases.

@dirk-thomas
Copy link
Member

otherwise I'll setup a mock build farm tonight.

You don't have to spin up a complete buildfarm. You can run every job type locally (the actual build will happen in Docker): e.g. https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/release_jobs.rst#run-the-release-job-locally / https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/devel_jobs.rst#run-the-devel-job-locally

I'll put it on our to-do list to move the tarball from http://packages.fetchrobotics.com/binaries/ to inside the git package for future releases.

I just wanted to mention it as good practice but you don't have to spend time on that in the near future. There is currently no plan to cut network access during the builds on the farm.

@dirk-thomas
Copy link
Member

it should pass this time

Merging...:crossed_fingers: :wink:

@dirk-thomas dirk-thomas merged commit f782c60 into ros:master Feb 20, 2019
@moriarty
Copy link
Contributor Author

Thanks!

@moriarty
Copy link
Contributor Author

otherwise I'll setup a mock build farm tonight.

You don't have to spin up a complete buildfarm. You can run every job type locally (the actual build will happen in Docker): e.g. https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/release_jobs.rst#run-the-release-job-locally / https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/devel_jobs.rst#run-the-devel-job-locally

Yes, I had followed most of those instructions but I think I missed this step:

https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/custom_rosdistro.rst#update-reference-to-custom-cache

@cjds
Copy link

cjds commented Feb 20, 2019

Passed. <3 Thanks everybody

http://build.ros.org/job/Mbin_uB64__fetch_drivers__ubuntu_bionic_amd64__binary/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants