Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ros2_socketcan release repository. #32079

Closed

Conversation

nuclearsandwich
Copy link
Member

This release repository was forked into ros2-gbp for the Galactic migration in April 2021 and has not been released into the upstream repository since.

Since the upcoming Rolling platform migration will again branch the release repository into ros2-gbp I recommend that we update it pre-emptively to reduce churn in the bloom configuration branches.

This release repository was forked into ros2-gbp for the Galactic migration in April 2021 and has not been released into the upstream repository since.

Since the [upcoming Rolling platform migration](#32036) will again branch the release repository into ros2-gbp I recommend that we update it pre-emptively to reduce churn in the bloom configuration branches.
@nuclearsandwich nuclearsandwich self-assigned this Feb 7, 2022
@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Feb 7, 2022
@nuclearsandwich
Copy link
Member Author

FYI @JWhitleyWork (apologies for the double ping, I have been processing these in alphabetical order)

Copy link
Contributor

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@JWhitleyWork
Copy link
Contributor

We had a release to do anyway so, if you're OK with it, #32088 can supercede this PR.

@nuclearsandwich
Copy link
Member Author

We had a release to do anyway so, if you're OK with it, #32088 can supercede this PR.

We're currently in a release hold for Rolling to facilitate the pending transition to Ubuntu Jammy so any releases to Rolling made right now would be closed with a recommendation to re-open them once the transition is complete.

Since #32088 is a leaf package I'm inclined to merge it but I wouldn't suggest making any further Rolling-targeted releases until after the transition is complete.

@nuclearsandwich
Copy link
Member Author

#32088 can supercede this PR.

It has superceded this PR.

@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/ros2_socketcan-release branch June 10, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants