add gentoo package for libatomic #35193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://packages.gentoo.org/packages/dev-libs/libatomic_ops needed to compile rcutils on ros galactic
tfoote
approved these changes
Nov 4, 2022
sloretz
requested changes
Nov 7, 2022
rosdep/base.yaml
Outdated
| @@ -2441,6 +2441,7 @@ libatomic: | |||
| arch: [gcc-libs] | |||
| debian: [libatomic1] | |||
| fedora: [libatomic] | |||
| gentoo: [dev-libs/libatomic_ops] | |||
There was a problem hiding this comment.
I'm not very familiar with Gentoo, but I'm not sure libatomic_ops is the right package. The Ubuntu package is only providing libatomic.so.1 and libatomic.so.1.2.0.
In the gentoo stage3 docker container I see those libs are provided by sys-devel/gcc.
gentoo:root> find / -name "libatomic.so*" 2>/dev/null
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1.2.0
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libatomic.so
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libatomic.so.1.2.0
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libatomic.so.1
gentoo:root> qfile /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so
sys-devel/gcc: /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so
gentoo:root> qfile /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1.2.0
sys-devel/gcc: /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1.2.0
gentoo:root> qfile /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1
sys-devel/gcc: /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/32/libatomic.so.1
There was a problem hiding this comment.
You are right it works if we use this dependency instead.
However, the tool superflore while fetching for every dependancy, would look for the name "libatomic" and then take the argument of gentoo in the yaml file.
Would that be alright if I replace libatomic_ops by sys-devel/gcc ?
changes are done according to the comment on PR ros#35193
sloretz
approved these changes
Nov 7, 2022
tfoote
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add the following dependency to the rosdep database.
Package name:
libatomic
Package Upstream Source:
https://gcc.gnu.org/
Purpose of using this:
In order to compile ros-galactic for gentoo with superflore, we need to add the gentoo package for libatomic.
Distro packaging links:
Links to Distribution Packages
Most of the packages have already been added in #29030
Related to ros-infrastructure/superflore#292