Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fold output for test_build_caches #38168

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

SubaruArai
Copy link
Contributor

@SubaruArai SubaruArai commented Aug 7, 2023

Adds output folding for test/test_build_caches.py.

Related: #25334, #38167

Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. @clalancette, any thoughts?

@SubaruArai
Copy link
Contributor Author

For future reference:

We might want to change how Fold enumerates the id for nested blocks.

# current
block 1 start
block 2 start
...
block 2 end
block 1 end

# proposed
block 1 start
block 1-1 start
...
block 1-1 end
block 1 end

@SubaruArai
Copy link
Contributor Author

The CI failed with a url timeout error, can someone with the permission trigger a re-run?

=================================== FAILURES ===================================
____________________________ test_rosdep_duplicates ____________________________

url = 'https://raw.githubusercontent.com/ros/rosdistro/master/hydro/distribution.yaml'
retry = 2, retry_period = 1, timeout = 10, skip_decode = False

    def load_url(url, retry=2, retry_period=1, timeout=10, skip_decode=False):
        try:
>           fh = urlopen(url, timeout=timeout)

...

FAILED test/rosdep_duplicates_test.py::test_rosdep_duplicates - socket.timeout: The read operation timed out (https://raw.githubusercontent.com/ros/rosdistro/master/hydro/distribution.yaml)

@SubaruArai
Copy link
Contributor Author

@clalancette ping

@clalancette clalancette merged commit 21000b4 into ros:master Aug 22, 2023
4 checks passed
@SubaruArai SubaruArai deleted the ci/fold_test_build_caches branch August 23, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants