Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uvloop to python rosdep index #38754

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

nachovizzo
Copy link
Contributor

@nachovizzo nachovizzo requested a review from a team as a code owner October 11, 2023 23:53
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Oct 11, 2023
@nachovizzo nachovizzo changed the title Add uvtool to python rosdep index Add uvloop to python rosdep index Oct 12, 2023
@nachovizzo
Copy link
Contributor Author

@quarkytale @tfoote

Could we merge this so I can continue with the release of #38753. Once uvloop is in rosdep I will also release the new version of ament-black for rolling and humble as well

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It will need a second review likely from our reviewer rotation.

@quarkytale quarkytale merged commit f685359 into ros:master Oct 13, 2023
4 checks passed
@nachovizzo nachovizzo deleted the python3-uvloop branch November 6, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants