Remove performance_test from rosdistro #42459
Conversation
Signed-off-by: LanderU <[email protected]>
LanderU
requested review from
nuclearsandwich,
cottsay and
quarkytale
as code owners
github-actions
bot
added
end-of-life
|
This pull request changes files for a ROS distribution that is no longer supported (End Of Life) and the distribution will not have any future syncs to include this change. |
audrow
added
the
changes requested
|
We normally don't modify EOL distros. I think removing a package may be an exception. I've asked in the OSRF slack. |
There was a problem hiding this comment.
For preventing the build failures this is overkill. To do that specifically you'll want to only remove the release stanzas. If you remove the entire entry you will also remove the indexing and documentation which means that the community won't be able to discover your packages anywhere near as easily.
did not get any feedback: https://gitlab.com/ApexAI/performance_test/-/issues/166
Note that you @ mentioned one developer on your own repository, which I don't think that they're watching. If you want help please use one of the support channels (such as robotics.stackexchange.com ) and not rely on a single ping of a single developer on a non-standard channel.
However I think that there's likely just some things that can be fixed to resolve your issues.
For example I took a quick look at the the Hdev test looks like it's failing for some linting errrors: https://build.ros2.org/job/Hdev__performance_test__ubuntu_jammy_amd64/79/ You should be able to fix those.
It is also flagged that the released version was out of date. Has it been attempted to review the errors and update the release?
| @@ -4427,21 +4427,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: ros2 | |||
| status: maintained | |||
| performance_test: | |||
There was a problem hiding this comment.
It looks like the new release has fixed the builds in rolling: https://build.ros2.org/job/Rbin_uN64__performance_test__ubuntu_noble_amd64__binary/
So reverting rolling seems incorrect and it seems like you are very close to being able to build on the other platforms as it works in your CI and on the build farm.
| doc: | ||
| type: git | ||
| url: https://gitlab.com/ApexAI/performance_test.git | ||
| version: 1.2.1 |
There was a problem hiding this comment.
This version looks like it was pinned to a version but not updated with the new releases.
| @@ -3884,21 +3884,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: foxy-devel | |||
| status: maintained | |||
| performance_test: | |||
There was a problem hiding this comment.
As @audrow mentioned please don't modify EOL distros. They do not have any builds running anymore and are more of just a snapshot of the old state for historical purposes. As being EOL we don't want to be maintaining them anymore.
| @@ -3072,21 +3072,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: foxy-devel | |||
| status: maintained | |||
| performance_test: | |||
| tags: | ||
| release: release/jazzy/{package}/{version} | ||
| url: https://github.com/ros2-gbp/performance_test-release.git | ||
| version: 2.0.0-2 |
There was a problem hiding this comment.
This version is failing because some module has flagged the rosdistro as unsupported. It seems that this should be resolvable potentially something has a hardcoded list of compatible versions.
https://build.ros2.org/job/Jbin_uN64__performance_test__ubuntu_noble_amd64__binary/115/console
00:01:55.303 CMake Error at CMakeLists.txt:500 (message):
00:01:55.303 Unsupported ROS_DISTRO
00:01:55.303
00:01:55.303
|
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
github-actions
bot
added
the
stale
|
Thanks @tfoote . I fixed the linting errors, and perhaps the JUnit error also. I should be able to slowly push this to a better place during the next several days. At the end of the jobs, several emails are sent. For example: https://build.ros2.org/job/Jdev__performance_test__ubuntu_noble_amd64/12/console Sending e-mails to: [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] How can we unsubscribe our personal email addresses from this list? |
The emails are an aggregate of the maintainers listed in the package.xml as well as any committers (from the git commits) who have committed to the branch under tests since the last successful build. Now that the build has gone green it should only be the package maintainers (with one email now saying it was successful to all the people who were notified in the past that it had failed,) And if there's a regression in the future it will be to the committers with changes since the last successful build. So you can control it by either adjusting the package.xml or changing what you use as your commit email. |
|
@tfoote thanks for the explanation. Now that it has gone green, what do I need to do here to update? I never really learned what this repo is for. Should I submit an MR to update version numbers to more recent tags? |
|
If there's new content making new releases would be great. To update a version here you should be running bloom to make a new release and it will automatically open the PR here when it's done for you with the new version. There's an overview here: https://docs.ros.org/en/jazzy/How-To-Guides/Releasing/Releasing-a-Package.html You'll be executing the subsequent releases section but I'd suggest reading through the other two for more context first. Bloom will make all the target platform specific tags in the release repos for you based on the tags that you point it at. The only real thing to be managed directly here might be the So I'm going to close this. And bloom should open new PRs for new versions. And if you have different branches for development on the different rosdistros you could update those for each distro as is appropriate. |
|
@tfoote thank you! |
|
@tfoote I updated all of the versions, and the build farm has a new error: https://build.ros2.org/job/Ibin_uJ64__performance_test__ubuntu_jammy_amd64__binary/542/ It looks like the job is being killed? But i don't see a reason why. Any ideas? |
|
Is this a compilation unit that uses a lot of memory? It might have been reaped by the oom killer. The farm is busy at the moment and we don't hard enforce memory limits. So it out another parallel build might have run over allocation. It will retry automatically, but I've bumped it to accelerate it too. |
|
@tfoote there's a good amount of template instantiation due to the wide variety of message types, so I would not be surprised if this is the case. Thanks for looking into it. |
Closes #42458