Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-streamz to rosdep/python.yaml #43502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galou
Copy link

@galou galou commented Nov 14, 2024

Please add the following dependency to the rosdep database.

Package name:

python3-streamz: Pipelines to manage continuous streams of data

Package Upstream Source:

https://github.com/python-streamz/streamz/

Purpose of using this:

We use streamz to apply a sliding window average on raw input data for logging and user interface.

Distro packaging links:

Links to Distribution Packages

@galou galou requested a review from a team as a code owner November 14, 2024 13:27
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Nov 14, 2024
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this package is available as system packages. Please use those instead of pip entries.

Key 'python3-streamz' might be satisfied by debian package named 'python3-streamz': https://packages.debian.org/bookworm/python3-streamz
Key 'python3-streamz' might be satisfied by opensuse package named 'python3-streamz': https://software.opensuse.org/package/python-streamz

rosdep/python.yaml Outdated Show resolved Hide resolved
@galou
Copy link
Author

galou commented Nov 18, 2024

There's also the package for Tumbleweed but I don't know how to add it (opensuse: [python-streamz]?).

@galou
Copy link
Author

galou commented Nov 18, 2024

What is preferred, should I rebase and squash or simply push a new commit?

@clalancette
Copy link
Contributor

What is preferred, should I rebase and squash or simply push a new commit?

Either one is fine. We'll end up squashing it in the end.

Comment on lines +9895 to +9897
bionic:
pip:
packages: [streamz]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bionic is EOL, so we don't need to add it:

Suggested change
bionic:
pip:
packages: [streamz]

debian:
bookworm: [python3-streamz]
bullseye: [python3-streamz]
ubuntu:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ubuntu:
opensuse: [python3-streamz]
ubuntu:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3-streamz is only available as experimental package if I understand correctly. Moreover, on Tumbleweed it is available as python-streamz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants