Rosidl generator advancement #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you import several things from a library in Python, you can also simply import these things as tuples. This allows you to significantly streamline the code.
Python has an implementation for tenary operators.
esteve
requested changes
Apr 19, 2024
There was a problem hiding this comment.
@Guelakais fix the permissions on the files, you've added the exectuable bit to all of them and it's not easy not see what the changes are.
|
@Guelakais we don't want to publish messages to crates.io, anyone could hijack the packages and introduce bugs via the dependencies, crates.io does not control who can or cannot publish a crate. Moreover, a message package can reference different ROS distributions (with different fields, for example), that's why publishing messages to crates.io is problematic, because there's only one distribution available there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have already announced in another pull request, I have been working with your package generator and have upgraded it so that it can generate almost publishable packages. The only thing you have to change manually are the respective version numbers of the packages in the Cargo.toml files. Automating this is also not trivial, which is why I haven't included it yet. In the end it's up to you. Personally, I saw publishing the packages on crates.io as the next logical step if you don't want to go the same way as r2r, for example, which delivers all possible interface dependencies directly with the main crate. This is also a possibility, even if it would of course bloat ros2 rust. I can definitely understand your point of view. Simply loading the entire ros2 type system onto crates can definitely lead to problems, especially if anyone does it.
At the same time, I didn't just beef up the generator, I streamlined it altogether. As far as I know, the most blatant changes to the part only affected 2 files and 4 lines of code in the end.