Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Drop unused data_files entry for example_processes (#680) #788

Closed
wants to merge 1 commit into from
Closed

[backport] Drop unused data_files entry for example_processes (#680) #788

wants to merge 1 commit into from

Conversation

xueying4402
Copy link

No description provided.

ahcorde
ahcorde approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to sign the commit ?

fujitatomoya
fujitatomoya approved these changes Jul 20, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (backport of #680)

i think humble support RHEL 8 (not 9, that probably because RHEL CI failed)

  • Linux-rhel Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Jul 23, 2024

friendly ping @xueying4402

@xueying4402
Copy link
Author

@ahcorde Thank you for pointing out the need for a sign-off. I want to clarify that this PR is a cherry-pick of a security-related commit from other branch, and I did not make any modifications to it. If there is a compliant way for me to add the sign-off information, I am happy to do so. (I have made an effort to find an appropriate method to add the sign-off, but unfortunately, I couldn't find one. )

Additionally, I had previously emailed regarding this matter but hadn't received a response. If there are any other adjustments needed, please let me know.

@clalancette
Copy link
Contributor

I'm going to side-step the whole issue here by closing this, and then asking the bot to backport #680 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xueying4402 @ahcorde @clalancette @fujitatomoya @cottsay